Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] sync master branch with upstream opendatahub stable branch #104

Merged

Conversation

harshad16
Copy link
Member

[master] sync master branch with upstream opendatahub stable branch

jiridanek and others added 9 commits August 7, 2024 17:15
…d policy and use digest to specify the image
…69-to-stable

[stable] Upgrade the x/net package v0.23.0 for the cve fix
…74-to-stable

[stable] RHOAIENG-9935: feat(nbcs): get ose-oauth-proxy image with PullIfNeeded policy and use digest to specify the image
https://issues.redhat.com/browse/RHOAIENG-11259

This name caused go vulnerability check to fail since this file is part
of the tests and relevant other test files weren't compiled because they
have their _test inffix as expected.

Note: this is also alignment to what is in v1.7-branch already.
[stable] Fix naming of the helper.go file so it follows the golang conventions
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Co-authored-by: Jiri Daněk <[email protected]>
[stable] RHOAIENG-7327: Set certs on both creation and update of notebooks
@jstourac
Copy link
Member

/lgtm

All is green, love that!

@harshad16
Copy link
Member Author

/lgtm
/approve

thanks for the review.

Copy link

openshift-ci bot commented Aug 28, 2024

@harshad16: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

thanks for the review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b83797d into red-hat-data-services:master Aug 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants