-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: fix(gha): replace oc
with kubectl
in notebook_controller_integration_test.yaml
#121
base: rhoai-2.14
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
btw, is this intended intentionally against this branch? Please, link this with relevant upstream change once possible as we should go from upstream first ideally. |
I wanted to quickly try... Also, I did the change in github webui and I can't edit multiple files that way |
…egration_test.yaml We don't have oc preinstalled on the new GitHub Actions runners that we were autoupdated to. Best to stick to kubectl.
7869af6
to
d77f11f
Compare
New changes are detected. LGTM label has been removed. |
@jiridanek , seems the CI still has some issue |
First, I think we should merge your revert independently of this one PR The ci fail here was a flaky failure, passed on rerun https://github.com/red-hat-data-services/kubeflow/actions/runs/11349164382; I'm adding a retry to the place where it failed in a different PR |
We don't have
oc
preinstalled on the new GitHub Actions runners that we were autoupdated to. Best to stick to kubectl.