Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: fix(gha): replace oc with kubectl in notebook_controller_integration_test.yaml #121

Open
wants to merge 1 commit into
base: rhoai-2.14
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Oct 15, 2024

We don't have oc preinstalled on the new GitHub Actions runners that we were autoupdated to. Best to stick to kubectl.

Copy link

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jstourac
Copy link
Member

btw, is this intended intentionally against this branch? Please, link this with relevant upstream change once possible as we should go from upstream first ideally.

@jiridanek
Copy link
Member Author

I wanted to quickly try... Also, I did the change in github webui and I can't edit multiple files that way

…egration_test.yaml

We don't have oc preinstalled on the new GitHub Actions runners that we were autoupdated to. Best to stick to kubectl.
Copy link

openshift-ci bot commented Oct 15, 2024

New changes are detected. LGTM label has been removed.

@harshad16
Copy link
Member

@jiridanek , seems the CI still has some issue
how do you wanna proceed with this ?

@jiridanek
Copy link
Member Author

jiridanek commented Oct 15, 2024

First, I think we should merge your revert independently of this one PR

The ci fail here was a flaky failure, passed on rerun https://github.com/red-hat-data-services/kubeflow/actions/runs/11349164382; I'm adding a retry to the place where it failed in a different PR

@jiridanek jiridanek closed this Oct 15, 2024
@jiridanek jiridanek reopened this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants