Sync master from odh v1.9-branch to get the latest changes ready for rhoai-nightly #125
+199
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troller` to update the yamls
…92-to-main [main] NO-JIRA: chore(nbcs): run `make generate` in `components/notebook-controller` to update the yamls
* ``` bin/setup-envtest use 1.23 -p path unable to find a version that was supported for platform darwin/arm64 ``` * align with operator's and opendatahub-io/notebooks's kustomize version * ``` make generate GOBIN=/Users/jdanek/IdeaProjects/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/controller-tools/cmd/[email protected] /Users/jdanek/IdeaProjects/kubeflow/components/odh-notebook-controller/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..." panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1008a00a4] ``` * manifest changes after regen * apply the same changes for notebook-controller as for odh-notebook-controller previously
Renamed the GHA fixing a typo
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.1.0 to 7.0.5. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@c5a7806...5e91468) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
[GHA] Update odh and notebook-controller with image main-7986030
…/peter-evans/create-pull-request-7.0.5 chore(gha): bump peter-evans/create-pull-request from 6.1.0 to 7.0.5
…egration_test.yaml We don't have oc preinstalled on the new GitHub Actions runners that we were autoupdated to. Best to stick to kubectl.
NO-JIRA: fix(gha): replace oc with kubectl in notebook_controller_integration_test.yaml
Without this, the gha is flaky and may fail with ``` notebook.kubeflow.org/minimal-notebook created Error from server (NotFound): statefulsets.apps "minimal-notebook" not found ```
…oxy image digest reference from 4.8 to the latest 4.14 version (#388)" We found at least one OCP cluster where this change causes restart of running notebooks when controller is updated from a previous version to a version with this fix present. To be safe, we'll roll this back and try again. We'll investigate that cluster to understand what's happening. This reverts commit 99e70bf.
NO-JIRA: fix(gha) improve robustness by checking for resource existence
…o jd_sync_v1.9-branch_from_main
Revert "[v1.9-branch] RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)"
Sync v1.9 branch from main to get the latest changes ready for rhoai-nightly
|
Looked it over /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sync v1.9 branch from main to get the latest changes ready for rhoai-nightly
openshift-merge-bot
bot
merged commit b33d7a2
into
red-hat-data-services:master
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to
Created using link
master...opendatahub-io:kubeflow:v1.9-branch