Skip to content

Fix ci to function with params of ODH-NBC RHOAI#62

Merged
openshift-merge-bot[bot] merged 1 commit intored-hat-data-services:masterfrom
harshad16:fix-ci-odh-nbc
Jun 19, 2024
Merged

Fix ci to function with params of ODH-NBC RHOAI#62
openshift-merge-bot[bot] merged 1 commit intored-hat-data-services:masterfrom
harshad16:fix-ci-odh-nbc

Conversation

@harshad16
Copy link
Copy Markdown

Fix ci to function with params of ODH-NBC RHOAI
Related-to: #61 (comment)

@jiridanek
Copy link
Copy Markdown
Member

@harshad16 the CI was already running before on your own fork, so here's result from that https://github.com/harshad16/odh-kubeflow/actions/runs/9521843160/job/26250153715

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Copy link
Copy Markdown
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last CI run in https://github.com/harshad16/odh-kubeflow/actions/runs/9522071266/job/26250836049 now failed on issue https://issues.redhat.com/browse/RHOAIENG-72 which is as expected. Thanks for the fix.

I'm adding the difference between opendatahub-io and red-hat-data-services manifests to the office hours agenda; hopefully we can agree on unifying the code across repos as much as possible.

@atheo89
Copy link
Copy Markdown
Member

atheo89 commented Jun 19, 2024

Thanks for the fix!

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants