Skip to content

Commit

Permalink
Make sure Pod Toleration setting is applied before running TC (#567)
Browse files Browse the repository at this point in the history
* Add sleep to ensure setting is applied

Signed-off-by: Luca Giorgi <[email protected]>

* Move sleep withing save changes keyword

Signed-off-by: Luca Giorgi <[email protected]>

Signed-off-by: Luca Giorgi <[email protected]>
  • Loading branch information
lugi0 authored Sep 21, 2022
1 parent 675702c commit 40de688
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 3 additions & 1 deletion tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,9 @@ Save Changes In Cluster Settings
Click Button Save changes
Wait Until Keyword Succeeds 30 1
... Wait Until Page Contains Settings changes saved.
# New setting applies after ~5-10s. Sleep here to make
# sure it is applied.
Sleep 10s

Enable "Usage Data Collection"
[Documentation] Once in Settings > Cluster Settings, enables "Usage Data Collection"
Expand Down Expand Up @@ -436,7 +439,6 @@ Restore PVC Value To Default Size
Wait Until Page Contains Element xpath://input[@id="pvc-size-input"] timeout=30
Click Button Restore Default
Save Changes In Cluster Settings
Sleep 20s msg=NOTE: This change will cause juypterhub to restart. It will take 30 seconds before juypterhub will be available. #robocop:disable

RHODS Notification Drawer Should Contain
[Documentation] Verifies RHODS Notifications contains given Message
Expand Down
1 change: 0 additions & 1 deletion tests/Tests/800__culler/culler.robot
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ Disable Notebook Culler
Click Element xpath://input[@id="culler-timeout-unlimited"]
Save Changes In Cluster Settings
END
Sleep 30s msg=Give time for rollout

Teardown
[Documentation] Teardown for the test
Expand Down

0 comments on commit 40de688

Please sign in to comment.