fix alerts

red-hat-data-services · Feb 27, 2024 · 5c141ee · 5c141ee
1 parent 37c30bd
commit 5c141ee
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/ods_ci/tests/Resources/CLI/Minio.resource b/ods_ci/tests/Resources/CLI/Minio.resource
@@ -3,6 +3,7 @@ Documentation       Collcetion of keywords to deploy and remove MinIO storage
 Library             OperatingSystem
 Resource            ../Common.robot
 
+
 *** Variables ***
 ${MINIO_RESOURCES_DIRPATH}=    ods_ci/tests/Resources/Files/minio
 ${MINIO_POD_FILEPATH}=    ${MINIO_RESOURCES_DIRPATH}/minio.yaml
@@ -30,11 +31,13 @@ Deploy MinIO
         Set Test Variable    ${route_name}
         Create File From Template    ${MINIO_POD_FILEPATH}    ${MINIO_RESOURCES_DIRPATH}/minio_filled.yaml
         ${rc}=    Run And Return Rc    oc new-project ${namespace}
-        ${rc}    ${out}=    Run And Return Rc And Output    oc apply -f ${MINIO_RESOURCES_DIRPATH}/minio_filled.yaml -n ${namespace}
+        ${rc}    ${out}=    Run And Return Rc And Output
+        ...    oc apply -f ${MINIO_RESOURCES_DIRPATH}/minio_filled.yaml -n ${namespace}
         Wait For Pods To Be Ready    label_selector=app=minio
         ...    namespace=${namespace}
     END
-    ${rc}    ${route}=    Run And Return Rc And Output    oc get route ${route_name} -n ${namespace} --template={{.spec.host}}
+    ${rc}    ${route}=    Run And Return Rc And Output
+    ...    oc get route ${route_name} -n ${namespace} --template={{.spec.host}}
     Should Be Equal As Integers    ${rc}    ${0}
     RETURN    ${route}
 
@@ -58,4 +61,4 @@ Get Minio Credentials
 Remove Minio
     [Documentation]    Delete the MinIO objects from the cluster
     Log    message=To Be Implemented
-    # for the time being the test using Minio is deleting the NS.
+    # for the time being the test using Minio is deleting the NS.
diff --git a/ods_ci/tests/Resources/CLI/ModelServing/llm.resource b/ods_ci/tests/Resources/CLI/ModelServing/llm.resource
@@ -55,7 +55,7 @@ Set Project And Runtime
     [Documentation]    Creates the DS Project (if not exists), creates the data connection for the models,
     ...                creates caikit runtime. This can be used as test setup
     [Arguments]    ${namespace}    ${enable_metrics}=${FALSE}    ${runtime}=caikit-tgis-runtime    ${protocol}=grpc
-    ...            ${access_key_id}=${S3.AWS_ACCESS_KEY_ID}    ${access_key}=${S3.AWS_SECRET_ACCESS_KEY} 
+    ...            ${access_key_id}=${S3.AWS_ACCESS_KEY_ID}    ${access_key}=${S3.AWS_SECRET_ACCESS_KEY}
     ...            ${endpoint}=${MODELS_BUCKET.ENDPOINT}    ${verify_ssl}=${TRUE}
     Set Up Test OpenShift Project    test_ns=${namespace}
     Create Secret For S3-Like Buckets    endpoint=${endpoint}
@@ -112,7 +112,6 @@ Create Secret For S3-Like Buckets
         ...    oc annotate secret ${name} -n ${namespace} serving.kserve.io/s3-verifyssl='false' --overwrite
         Should Be Equal As Integers    ${rc}    ${0}
     END
-
 
 Compile Inference Service YAML
     [Documentation]    Prepare the Inference Service YAML file in order to deploy a model

diff --git a/ods_ci/tests/Resources/Files/minio/minio.yaml b/ods_ci/tests/Resources/Files/minio/minio.yaml
@@ -34,6 +34,7 @@ metadata:
     app: minio
   name: ${podname}
 spec:
+  automountServiceAccountToken: false
   containers:
     - args:
         - server
@@ -45,4 +46,11 @@ spec:
           value: ${pw}
       image: ${minio_image}
       imagePullPolicy: Always
-      name: minio
+      name: minio
+      resources:
+        limits:
+          cpu: 250m
+          memory: 10Gi
+        requests:
+          cpu: 20m
+          memory: 400Mi