Skip to content

Commit

Permalink
[Fix] the test for the package versions on images
Browse files Browse the repository at this point in the history
In the second part of this test, we have a selected list of packages so
that we expect these packages to be same version amongst all the tested
images. We have to reduce this list as now there are more packages that
are expected not to be in the same version as was in past.
  • Loading branch information
jstourac committed Oct 14, 2024
1 parent 9a9aa79 commit b1583d2
Showing 1 changed file with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ Verify Installed Labextension Version
Check Versions In JupyterLab
[Arguments] ${libraries-to-check}
${return_status} = Set Variable PASS
@{packages} = Create List Python Boto3 Kafka-Python Matplotlib Scikit-learn Pandas Scipy Numpy
FOR ${libString} IN @{libraries-to-check}
# libString = LibName vX.Y -> libDetail= [libName, X.Y]
@{libDetail} = Split String ${libString} ${SPACE}v
Expand Down Expand Up @@ -531,12 +530,18 @@ Check Versions In JupyterLab
${return_status} = Set Variable FAIL
END
END

# Now check that selected list of packages has same version among all the images.
@{packages} = Create List Python Boto3 Kafka-Python Scipy

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create List can be replaced with VAR

Continue For Loop If "${libDetail}[0]" not in ${packages}
IF "${libDetail}[0]" not in ${package_versions}
... Set To Dictionary ${package_versions} ${libDetail}[0]=${libDetail}[1]
IF "${package_versions["${libDetail}[0]"]}" != "${libDetail}[1]"
${return_status} = Set Variable FAIL
Run Keyword And Continue On Failure FAIL "${package_versions["${libDetail}[0]"]} != ${libDetail}[1]"
Run Keyword And Continue On Failure Fail
... Version of this library in this image doesn't align with versions in other images
... "${package_versions["${libDetail}[0]"]} != ${libDetail}[1]"
END
END
RETURN ${return_status}
Expand Down

0 comments on commit b1583d2

Please sign in to comment.