Remove SMMR clean up from KServe test teardown #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Robot Results
|
bdattoma
added
needs testing
jstourac
reviewed
Dec 15, 2023
Signed-off-by: bdattoma <[email protected]>
robocop alerts fixed (unless new ones appear after the check runs again). PR validation: |
bdattoma
added
verified
jstourac
approved these changes
Dec 15, 2023
|
jgarciao
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kserve tests try to delete the test namespace from the ServiceMeshMemberRoll (SMMR) but most of the time it fails, because the model controller does it automatically (it wasn't like this in origin, but then it got fixed).
This PR is removing the SMMR clean up and replace it with a check to ensure that the model controller actually does it automatically.