Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-23 - Cleanup CodeFlare installation code #1180

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

jiripetrlik
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
424 0 0 424 100

Library Process


*** Keywords ***
Uninstalling RHODS Operator
${is_codeflare_managed} = Is CodeFlare Managed
IF ${is_codeflare_managed} Uninstalling CodeFlare Operator
${is_operator_installed} = Is RHODS Installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this line should stay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sutaakar
Yes, it is true. Thank you for noticing it. It should be fixed now.

sutaakar
sutaakar previously approved these changes Feb 8, 2024
jgarciao
jgarciao previously approved these changes Feb 13, 2024
@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Feb 13, 2024
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jiripetrlik jiripetrlik marked this pull request as ready for review February 27, 2024 09:06
@jiripetrlik
Copy link
Contributor Author

@sutaakar @jgarciao
Hello, can you please approve again? I had to rebase this PR.

@jgarciao jgarciao self-requested a review February 27, 2024 11:24
@jiripetrlik jiripetrlik merged commit 9f54e41 into red-hat-data-services:master Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants