Add TGIS test for fetching model from Minio object storage #1231
Conversation
bdattoma
added
needs testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| name: ods-ci-minio | ||
| spec: | ||
| containers: | ||
| - args: |
Check warning
Code scanning / SonarCloud
CPU limits should be enforced
| name: ods-ci-minio | ||
| spec: | ||
| containers: | ||
| - args: |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced
| labels: | ||
| app: minio | ||
| name: ods-ci-minio | ||
| spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods
There was a problem hiding this comment.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
bdattoma
added
verified
not related to this PR. It is a warning about using random generator, but it is fine for our use case cc: @lugi0 |
bdattoma
requested review from
jiridanek,
diegolovison,
jstourac,
FedeAlonso and
asanzgom
| *** Keywords *** | ||
| Deploy MinIO | ||
| [Documentation] Deploys MiniIO pod, service and route using the given ${minio_image} | ||
| [Arguments] ${minio_image}=quay.io/modh/ods-ci-minio-models:1.0 |
There was a problem hiding this comment.
Use digest for the compatibility for disconnected cluster
There was a problem hiding this comment.
Hi @bdattoma why do you deploy the Minio? In a disconencted env it is already available.
It is enough just to check test-variables.yaml
There was a problem hiding this comment.
will discuss offline
...400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_tgis_object_storages.robot
Show resolved
Hide resolved
|
Covering RHOAIENG-3490.
PR validation (including regression):
rhods-ci-pr-test/2529PASSre-test minio TC after applying Tarun's comment:
rhods-ci-pr-test/2531PASS