Stabilize Dashboard Test Suite (415) #1235
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
manosnoam
force-pushed
the
dashboard_415
branch
from
38cb1f8
to
0ae5381
Compare
| ... prj_title=${PRJ_TITLE} image_name=${NB_IMAGE} deployment_size=Small | ||
| ... storage=Persistent pv_existent=${NONE} | ||
| ... pv_name=${NONE} pv_description=${NONE} pv_size=${NONE} | ||
| ${workbenches}= Create List ${WORKBENCH_TITLE} |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
| @@ -276,7 +278,7 @@ | |||
| # The Workbench and the Data connection appear on the project details page. | |||
| Workbench Should Be Listed workbench_title=${WORKBENCH_TITLE} | |||
| # The data connection has the workbench name in the "Connected workbenches" column | |||
| ${workbenches}= Create Dictionary ${WORKBENCH_TITLE}=mount-data | |||
| ${workbenches}= Create List ${WORKBENCH_TITLE} | |||
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
| # The returned list can be evaluated with keyword: Should Contain ${text_list} Text Data | ||
| [Arguments] ${parent_element} | ||
| ${elements}= Get WebElements ${parent_element} | ||
| ${text_list}= Create List |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
| RETURN ${text_list} | ||
|
|
||
| Get All Strings That Contain | ||
| [Documentation] Returns new list of strings, for each item in ${list_of_strings} that contains ${substring_to_search} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| Get All Strings That Contain | ||
| [Documentation] Returns new list of strings, for each item in ${list_of_strings} that contains ${substring_to_search} | ||
| [Arguments] ${list_of_strings} ${substring_to_search} | ||
| ${matched_list}= Create List |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
manosnoam
force-pushed
the
dashboard_415
branch
from
0ae5381
to
eb79032
Compare
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Outdated
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Storages.resource
Outdated
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Storages.resource
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Storages.resource
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Storages.resource
Outdated
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource
Show resolved
Hide resolved
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource
Outdated
Show resolved
Hide resolved
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot
Show resolved
Hide resolved
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot
Show resolved
Hide resolved
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot
Outdated
Show resolved
Hide resolved
|
Verified on local IDE as well as on rhods-ci-pr-test/2533, by running all of our smoke + 'Dashboard" tag tests |
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Storages.resource
Fixed
Show fixed
Hide fixed
| IF ${oauth_prompt_visible} Click Button Log in with OpenShift | ||
| ${login-required} = Is OpenShift Login Visible | ||
| ${login-required}= Is OpenShift Login Visible |
Check notice
Code scanning / Robocop
Use underscore in variable name '{{ variable_name }}' instead of hyphens to avoid treating them like minus sign Note test
| IF ${login-required} Login To Openshift ${ocp_user_name} ${ocp_user_pw} ${ocp_user_auth_type} | ||
| ${authorize_service_account} = Is rhods-dashboard Service Account Authorization Required | ||
| ${authorize_service_account}= Is rhods-dashboard Service Account Authorization Required |
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention Warning test
| ... xpath://td[@data-label="Name"]/div/div/div[.="${image_name} "]/../../../../td[@data-label="Description" and .="${expected_description}"] # robocop: disable | ||
| IF ${exists}==False | ||
| ${desc} = Get Text xpath://td[@data-label="Name"]/div/div/div[.="${image_name} "]/../../../../td[@data-label="Description"] | ||
| ${desc}= Get Text xpath://td[@data-label="Name"]/div/div/div[.="${image_name} "]/../../../../td[@data-label="Description"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| @@ -782,7 +785,7 @@ | |||
|
|
|||
| Get Links From Switcher | |||
| [Documentation] Returns the OpenShift Console and OpenShift Cluster Manager Link | |||
| ${list_of_links} = Create List | |||
| ${list_of_links}= Create List | |||
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
| @@ -256,8 +258,10 @@ | |||
|
|
|||
| Wait Until Cards Are Loaded | |||
| [Documentation] Waits until the Application cards are displayed in the page | |||
| Run Keyword And Continue On Failure Wait Until Page Contains Element | |||
| ... xpath:${CARDS_XP} timeout=15s error="This might be caused by bug RHOAIENG-404" | |||
| ${status}= Run Keyword and Return Status Wait Until Page Contains Element | |||
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention Warning test
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Storages.resource
Fixed
Show fixed
Hide fixed
Fix known Automation bugs and general stability of Dashboard Suite 415. It also includes fixes to Keywords in Storages, Workbenches and Projects resources, that are being used by this suite: - `Create PersistentVolume Storage` option to update existing PVC - Fix supported mount name with to lower case and dashes only - `Workbench Should Be Listed` with timeout option - Fix `Select Existing Data Connection` in Workbench - `Wait Until Project Is Open` first waits for spinner ball to disappear - `Open Workbench` waits for workbench link, before clicking it - `Verify Cluster Settings Is Available` by `data-testid` - Increase timeout waiting to switch to/from JupyterLab console - New Storage KW: `Delete All PVC In Project From CLI` - New Common KW: `Get All Text Under Element` - New Common KW: `Get All Strings That Contain` - Removed All Tags of Product/Automation Bugs (All Suite Tests Passed) - Append to Suite 415: `Test Tags Dashboard` Signed-off-by: manosnoam <[email protected]>
Signed-off-by: manosnoam <[email protected]>
Signed-off-by: manosnoam <[email protected]>
Signed-off-by: manosnoam <[email protected]>
Signed-off-by: manosnoam <[email protected]>
manosnoam
force-pushed
the
dashboard_415
branch
from
54e4733
to
59ede15
Compare
|
@bdattoma I fixed/answered all of your suggestions, and rerun the whole suite (including sanity and tier1) + smoke of rhods-ci-pr-test/2537 - All tests passed!
|
manosnoam
added
verified
|
Fix known Automation bugs and general stability of Dashboard Suite:
415__ods_dashboard_projects.robot.
It also includes fixes to the Storages, Workbenches and Projects resources that are being used by this suite:
Create PersistentVolume Storageoption to update existing PVCWorkbench Should Be Listedwith timeout optionSelect Existing Data Connectionin WorkbenchWait for RHODS Dashboard to Loadwith retry logic to reload cardsWait Until Project Is Openfirst waits for spinner ball to disappearOpen Workbenchwaits for workbench link, before clicking itDelete All PVC In Project From CLIGet All Text Under ElementGet All Strings That ContainTest Tags DashboardAll 23 Test cases (including Smoke, Sanity and Tier1) passed: