Fix Pipelines E2E testing #1833

diegolovison · 2024-09-19T17:48:52Z

Fix Pipelines E2E testing

sh run_robot_test.sh --set-urls-variables true --extra-robot-args '-L DEBUG -i ODS-2632' --skip-oclogin

Tests.Data Science Pipelines.Test-Run-Data-Science-Pipelines-Operator-E2E-T...
==============================================================================
[ WARN ] No Prometheus namespace found
Run Data Science Pipelines Operator Integration Tests :: Run Data ... | PASS |
------------------------------------------------------------------------------
Tests.Data Science Pipelines.Test-Run-Data-Science-Pipelines-Opera... | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests.Data Science Pipelines                                          | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests                                                                 | PASS |
1 test, 1 passed, 0 failed
==============================================================================

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

github-actions · 2024-09-19T17:53:15Z

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
545	0	0	545	100

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

@@ -25,9 +24,11 @@
    ...     DataSciencePipelines-Backend
    ...     Tier1
    ...     ODS-2632    AutomationBug
+    # Store login information into dedicated config
+    Login To OCP Using API And Kubeconfig    ${OCP_ADMIN_USER.USERNAME}    ${OCP_ADMIN_USER.PASSWORD}    ${KUBECONFIGPATH}


.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

    Log    ${output}
    Should Be Equal As Integers	   ${return_code}	 0  msg= Run Data Science Pipelines Operator Integration Tests failed

 #robocop: disable: line-too-long
 *** Keywords ***
 Prepare Data Science Pipelines Operator Integration Tests Suite
    [Documentation]    Prepare Data Science Pipelines Operator Integration Tests Suite
-    ${return_code}    ${output}     Run And Return Rc And Output    rm -fR ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
+    ${return_code}    ${output}     Run And Return Rc And Output    rm -fR ${DSPO_SDK_DIR}


.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

    Log    ${output}
-    ${return_code}    ${output}     Run And Return Rc And Output    git clone ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL} ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
+    ${return_code}    ${output}     Run And Return Rc And Output    git clone ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL} ${DSPO_SDK_DIR}


.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

    Log    ${output}
-    Should Be Equal As Integers	   ${return_code}	 0  msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
-    ${return_code}    ${output}     Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && git checkout -b it_test origin/${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}
+    Should Be Equal As Integers	   ${return_code}	 0  msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DSPO_SDK_DIR}


.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

-    Should Be Equal As Integers	   ${return_code}	 0  msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
-    ${return_code}    ${output}     Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && git checkout -b it_test origin/${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}
+    Should Be Equal As Integers	   ${return_code}	 0  msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DSPO_SDK_DIR}
+    ${return_code}    ${output}     Run And Return Rc And Output    cd ${DSPO_SDK_DIR} && git checkout -b it_test origin/${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}


.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

-    Should Be Equal As Integers	   ${return_code}	 0  msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
-    ${return_code}    ${output}     Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && git checkout -b it_test origin/${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}
+    Should Be Equal As Integers	   ${return_code}	 0  msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DSPO_SDK_DIR}
+    ${return_code}    ${output}     Run And Return Rc And Output    cd ${DSPO_SDK_DIR} && git checkout -b it_test origin/${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}


.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

@@ -27,26 +26,21 @@
    ...     ODS-2632    AutomationBug
    ${openshift_api}    Get Openshift Server
    Log    ${openshift_api}
-    ${return_code}    ${output}    Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && make integrationtest K8SAPISERVERHOST=${openshift_api} DSPANAMESPACE=${DSPANAMESPACE} KUBECONFIGPATH=${KUBECONFIGPATH}
+    ${return_code}    ${output}    Run And Return Rc And Output    cd ${DSPO_SDK_DIR} && GIT_WORKSPACE=${DSPO_SDK_DIR} sh .github/scripts/tests/tests.sh --rhoai --k8s-api-server-host ${openshift_api} --kube-config ${KUBECONFIGPATH} --dspa-path ${DSPO_SDK_DIR}/tests/resources/dspa.yaml --external-dspa-path ${DSPO_SDK_DIR}/tests/resources/dspa-external.yaml --clean-infra --endpoint-type route


bdattoma · 2024-10-14T07:46:31Z

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

-    ${rc}    ${out}=    Run And Return Rc And Output    oc new-project ${DSPANAMESPACE}
-    Should Be Equal As Integers	   ${rc}	 0  msg=Cannot create a new project ${DSPANAMESPACE}
-
-Teardown Data Science Pipelines Operator Integration Tests Suite


is the teardown/cleanup implemented in the https://github.com/red-hat-data-services/ods-ci/pull/1833/files#diff-0639f9a87a08627ad0f0742ca7d12ea4ac9ad2a21072e8d216a04d60f43994b9R29 itself?

Yes. We delegate to the DSPO test suite.

bdattoma · 2024-10-14T07:47:07Z

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

@@ -27,26 +26,21 @@ Run Data Science Pipelines Operator Integration Tests
    ...     ODS-2632    AutomationBug


is the "AutomationBug" tag still needed?

Fixed. Thanks

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

sonarcloud · 2024-10-14T12:04:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jgarciao · 2024-10-14T16:32:32Z

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot

    ${openshift_api}    Get Openshift Server
    Log    ${openshift_api}
-    ${return_code}    ${output}    Run And Return Rc And Output    cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && make integrationtest K8SAPISERVERHOST=${openshift_api} DSPANAMESPACE=${DSPANAMESPACE} KUBECONFIGPATH=${KUBECONFIGPATH}
+    ${return_code}    ${output}    Run And Return Rc And Output    cd ${DSPO_SDK_DIR} && GIT_WORKSPACE=${DSPO_SDK_DIR} sh .github/scripts/tests/tests.sh --rhoai --k8s-api-server-host ${openshift_api} --kube-config ${KUBECONFIGPATH} --dspa-path ${DSPO_SDK_DIR}/tests/resources/dspa.yaml --external-dspa-path ${DSPO_SDK_DIR}/tests/resources/dspa-external.yaml --clean-infra --endpoint-type route


The tests take a while to run. Could you try to use the Run And Watch Command keyword in Common.robot so we'll be able to see the results in the Console in realtime? (in this or a follow-up PR)

github-advanced-security bot found potential problems Sep 19, 2024

View reviewed changes

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot Fixed Show fixed Hide fixed

diegolovison force-pushed the e2e branch from 60f9e73 to 279bcab Compare September 24, 2024 12:55

github-advanced-security bot found potential problems Sep 24, 2024

View reviewed changes

diegolovison force-pushed the e2e branch 4 times, most recently from beace17 to 0e73185 Compare September 30, 2024 17:55

github-advanced-security bot found potential problems Sep 30, 2024

View reviewed changes

diegolovison force-pushed the e2e branch from 0e73185 to 3479026 Compare October 9, 2024 17:58

github-advanced-security bot found potential problems Oct 9, 2024

View reviewed changes

diegolovison force-pushed the e2e branch from 3479026 to 37eeeb2 Compare October 11, 2024 19:28

diegolovison marked this pull request as ready for review October 11, 2024 19:31

bdattoma reviewed Oct 14, 2024

View reviewed changes

.../1100__data_science_pipelines/1110__test-run-data-science-pipelines-operator-e2e-tests.robot Show resolved Hide resolved

Fix Pipelines E2E testing

ccb1dfd

diegolovison force-pushed the e2e branch from 37eeeb2 to ccb1dfd Compare October 14, 2024 12:04

bdattoma approved these changes Oct 14, 2024

View reviewed changes

jgarciao approved these changes Oct 14, 2024

View reviewed changes

diegolovison merged commit f49726c into red-hat-data-services:master Oct 14, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Pipelines E2E testing #1833

Fix Pipelines E2E testing #1833

diegolovison commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

bdattoma Oct 14, 2024 •

edited

Loading

diegolovison Oct 14, 2024

bdattoma Oct 14, 2024

diegolovison Oct 14, 2024

sonarcloud bot commented Oct 14, 2024

jgarciao Oct 14, 2024

		@@ -27,26 +26,21 @@ Run Data Science Pipelines Operator Integration Tests
		... ODS-2632 AutomationBug

Fix Pipelines E2E testing #1833

Fix Pipelines E2E testing #1833

Conversation

diegolovison commented Sep 19, 2024 • edited Loading

github-actions bot commented Sep 19, 2024 • edited Loading

Robot Results

bdattoma Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

diegolovison Oct 14, 2024

Choose a reason for hiding this comment

bdattoma Oct 14, 2024

Choose a reason for hiding this comment

diegolovison Oct 14, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Oct 14, 2024

Quality Gate passed

jgarciao Oct 14, 2024

Choose a reason for hiding this comment

diegolovison commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

bdattoma Oct 14, 2024 •

edited

Loading