Remove Deprovision on failure from OCP provisioning task #1924
+2
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
kobihk
reviewed
Oct 14, 2024
kobihk
reviewed
Oct 14, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Log Cluster '${cluster_name}' has previously failed to be provisioned - Cleaning Hive resources | ||
| ... console=True | ||
| Delete Cluster Configuration | ||
| FAIL Cluster '${cluster_name}' has previously failed to be provisioned but some Hive and/or Cloud resources are still present. |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
bdattoma
added
verified
kobihk
approved these changes
Oct 15, 2024
|
aloganat
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the deprovisioning of the OCP cluster - when the provisioning fails - from the task for 2 reasons:
401 UnauthorizederrorPR validation:
rhoai-test-flow/826PASS - rhoai deployment failed because I put a wrong setting, but cluster provisioning worked just fine)