Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated test to verify AMD GPU's can be used in Data Science Pipelines #1932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automated test to verify AMD GPU's can be used in Data Science Pipelines #1932

wants to merge 1 commit into from

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Oct 15, 2024 •
edited
Loading

Tested on Azure with mi300x

sh run_robot_test.sh --set-urls-variables true --extra-robot-args '-L DEBUG -i AMD-GPUs' --skip-oclogin

Verify Pipeline Tasks Run On AMD GPU Nodes Only When Tolerations A... | PASS |
------------------------------------------------------------------------------
Tests.Data Science Pipelines.Data-Science-Pipelines-Gpu :: Basic a... | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests.Data Science Pipelines                                          | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests                                                                 | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Output:  /home/dlovison/github/rhods/ods-ci/ods_ci/test-output/ods-ci-2024-10-15-16-01-HEMIY4BvUv/output.xml
XUnit:   /home/dlovison/github/rhods/ods-ci/ods_ci/test-output/ods-ci-2024-10-15-16-01-HEMIY4BvUv/xunit_test_result.xml
Log:     /home/dlovison/github/rhods/ods-ci/ods_ci/test-output/ods-ci-2024-10-15-16-01-HEMIY4BvUv/log.html
Report:  /home/dlovison/github/rhods/ods-ci/ods_ci/test-output/ods-ci-2024-10-15-16-01-HEMIY4BvUv/test_report.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
546 0 0 546 100

@diegolovison diegolovison force-pushed the ray_amd_pipe branch 2 times, most recently from e160f1c to cb6b9f8 Compare October 15, 2024 19:08
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
ods_ci/tests/Tests/1100__data_science_pipelines/1105__data-science-pipelines-gpu.robot
Comment on lines +29 to +30
# robocop: off=too-long-test-case
Verify Pipeline Tasks Run On AMD GPU Nodes Only When Tolerations Are Added

Check warning

Code scanning / Robocop

Invalid number of empty lines between test cases ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between test cases (0/1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add one more it complains as well

ods_ci/tests/Tests/1100__data_science_pipelines/1105__data-science-pipelines-gpu.robot Fixed Show fixed Hide fixed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgarciao jgarciao self-requested a review October 16, 2024 08:30
@jgarciao jgarciao self-requested a review October 16, 2024 09:52
@diegolovison diegolovison marked this pull request as ready for review October 16, 2024 12:30
@diegolovison diegolovison added the verified This PR has been tested with Jenkins label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma left review comments

@jgarciao jgarciao jgarciao approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegolovison @jgarciao @bdattoma