Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: refactor dashboard manifests #306

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Jul 15, 2024

partially cherrypick opendatahub-io#1065
to keep other part not included, which will be done in "sync" PR

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request contains description of the issue
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request

Description

JIRA issue:

ref: https://issues.redhat.com/browse/RHOAIENG-8510

How Has This Been Tested?

Screenshot or short clip:

Merge criteria:

  • Have a meaningful commit messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jul 16, 2024

@zdtsw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhoai-operator-pr-image-mirror c0c6628 link true /test rhoai-operator-pr-image-mirror
ci/prow/rhoai-operator-e2e c0c6628 link true /test rhoai-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zdtsw
Copy link
Author

zdtsw commented Jul 16, 2024

/test rhoai-operator-e2e

Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VaishnaviHire,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaishnaviHire VaishnaviHire merged commit 873fd5f into red-hat-data-services:main Jul 16, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants