Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE]update: set go version to be the one we use from go.mod #382

Open
wants to merge 2 commits into
base: rhoai-2.13
Choose a base branch
from
Open

[DO NOT MERGE]update: set go version to be the one we use from go.mod #382

wants to merge 2 commits into from

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Oct 16, 2024 •
edited
Loading

Description

seem the go version for check-file-updates.yaml is on 1.23.2
just to use the same 1.21 coz that might be problem for generate target

if this works with 2.13 release, we shoud backport it to "main" branch

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw changed the base branch from main to rhoai-2.13 October 16, 2024 08:12
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 16, 2024

@zdtsw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-index f36163d link true /test ci-index
ci/prow/images f36163d link true /test images
ci/prow/rhods-operator-e2e f36163d link true /test rhods-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw changed the title update: set go version to be the one we use from go.mod [DO NOT MERGE]update: set go version to be the one we use from go.mod Oct 16, 2024
@zdtsw zdtsw force-pushed the fixgha branch 2 times, most recently from e6d84af to de8727d Compare October 16, 2024 11:24
@AjayJagan @zdtsw
(fix): Change on trigger event to pull_request_target in the "Check…
099f10c 
… config and readme updates / Ensure generated files are included (pull_request)" action to fix "Resource not accessible by integration" error while running the action (opendatahub-io#1296)

Signed-off-by: AJAY JAGANATHAN <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdtsw @openshift-merge-robot @AjayJagan