controllers: remove storageclaim from manager and move functionality #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
first cut of removal of storageclaim controller and moving the work over to the storageclient controller. Existing resources that are owned by storageclaims will become unmanaged but protected against deletion due to finalizer for which current expectation is to be removed manually no provider changes done atm and the expectation is, provider would send info that it used to send for storageclaim now to storageclient and any opportunity to change the message struct will be made and corresondingly a new PR will be raised. Signed-off-by: Leela Venkaiah G <[email protected]>
|
/hold Against any accidental approvals. |
Signed-off-by: Leela Venkaiah G <[email protected]>
|
closing in favour of #295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first cut of removal of storageclaim controller and moving the work over to the storageclient controller. Existing resources that are owned by storageclaims will become unmanaged but protected against deletion due to finalizer for which current expectation is to be removed manually
no provider changes done atm and the expectation is, provider would send info that it used to send for storageclaim now to storageclient and any opportunity to change the message struct will be made and corresondingly a new PR will be raised.