Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: fix predicate to trigger reconcile for mmode controller #288

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

rewantsoni
Copy link
Member

add an predicate.Or trigger reconcile of mmode controller when the storageClient's status is updated

@rewantsoni
Copy link
Member Author

/jira backport release-4.18

@openshift-ci-robot
Copy link

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

trigger reconcile of mmode controller when the storageClient's
status is updated

Signed-off-by: Rewant Soni <[email protected]>
@rewantsoni
Copy link
Member Author

rewantsoni commented Dec 4, 2024

Testing:

without restarting the operator, mmode status was updated
[rewantsoni scripts] k get po | grep client
ocs-client-operator-console-7f75dbbb6d-dg95n                      1/1     Running     0               2d4h
ocs-client-operator-controller-manager-7b7b5df754-hhtrx           2/2     Running     0               4m51s
storageclient-737342087af10580-status-reporter-28888415-sntq8     0/1     Completed   0               30s
Screenshot 2024-12-04 at 3 06 48 PM

Copy link

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4b75856 into red-hat-storage:main Dec 4, 2024
10 checks passed
@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #291

In response to this:

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants