Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: webhook for restricting storageclaims to auto created ones #292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 9, 2024

we only support a single storageclaim of a specific type created corresponding to a storageclient and this webhook ensures that support.

this helps in avoiding surprises during storageclaim controller removal.

Copy link

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
@leelavg
Copy link
Contributor Author

leelavg commented Dec 9, 2024

/hold

for testing.

we only support a single storageclaim of a specific type created
corresponding to a storageclient and this webhook ensures that support.

this helps in avoiding surprises during storageclaim controller removal.

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg leelavg requested a review from Madhu-1 December 9, 2024 09:19
Copy link
Member

@rewantsoni rewantsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are reconciling both subscription and storageClaim webhooks, can we rename reconcileSubscriptionValidatingWebhook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants