Bug 2247735: Adding toleration to schedule CSI pods on master nodes

[rchikatw]

Adding toleration to schedule CSI pods on master nodes

[openshift-ci]

@rchikatw: This pull request references Bugzilla bug 2247735, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2247735: Adding toleration to schedule CSI pods on master nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rchikatw: This pull request references Bugzilla bug 2247735, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2247735: Adding toleration to schedule CSI pods on master nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Madhu-1]

it looks like this is deprecated and replaced with control-plane https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-master-taint, please check what we have in supported OCP versions

[rchikatw]

checked one of the fusion hci clusters the key was "node-role.kubernetes.io/master". we can go with this key

[Madhu-1]

please test and change and see if its working as expected

[leelavg]

@Madhu-1 and @rchikatw

• I'm wondering why not runCSIDaemonSetOnAllNodes and use Toleration{Operator: TolerationExists}

Reasoning being,

• no need to find and set the Toleration.Key explicitly.
• Only if workloads are scheduled on tainted nodes then only CSI pods does actual work (this is a con as well, they are always there consuming resources)
• let the default be false (or not set) to conform to existing deployments and take the input from Subscription .spec.config.env (or what is the planned deployment model, iirc env will be reset if not set in CSV?)

[Madhu-1]

@Madhu-1 and @rchikatw

• I'm wondering why not runCSIDaemonSetOnAllNodes and use Toleration{Operator: TolerationExists}

The requirement was to run daemonset pods also on master node but not the nodes which might have tainted for something else.

Reasoning being,

• no need to find and set the Toleration.Key explicitly.
• Only if workloads are scheduled on tainted nodes then only CSI pods does actual work (this is a con as well, they are always there consuming resources)
• let the default be false (or not set) to conform to existing deployments and take the input from Subscription .spec.config.env (or what is the planned deployment model, iirc env will be reset if not set in CSV?)

👍🏻 default is true but it need to be added to env to avoid upgrade problem

[leelavg]

@rchikatw could you pls fix commitlint https://github.com/red-hat-storage/ocs-client-operator/actions/runs/6930384492/job/18849951078#step:4:25?

[nb-ohad]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nb-ohad, rchikatw

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rchikatw: All pull requests linked via external trackers have merged:

• red-hat-storage/ocs-client-operator#40

Bugzilla bug 2247735 has been moved to the MODIFIED state.

In response to this:

Bug 2247735: Adding toleration to schedule CSI pods on master nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.