Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHSTOR-5205] Lock client operator upgrade if it current matches provider operator version #47

Closed
wants to merge 8 commits into from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 18, 2023

  • Provider operator sends it's version as a response to the heartbeat mechanism
  • Client operator should take that into account and place a not upgradeable condition if it currently matches provider operator version
  • Failing to do above may result in client getting ahead of provider and interfere with communications among others
  • Conversely, unlock the upgrades if we are currently not matching provider operator version

rebased on #46 and functionally dependent on red-hat-storage/ocs-operator#2329

Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
- provider server makes it mandatory to  supply client operator version
for successful onboarding

Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg leelavg marked this pull request as draft December 18, 2023 08:14
Copy link

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Lock client operator upgrade via OLM OperatorCondition if it currently
match provider operator
- Unlock client operator upgrades if not above or the storageclient is
marked for deletion

Signed-off-by: Leela Venkaiah G <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leelavg
Copy link
Contributor Author

leelavg commented Jan 4, 2024

superseded by #53

@leelavg leelavg closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants