Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ocs-operator dependencies #49

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 20, 2023

Updates:

  1. ocs-operator to main
  2. code changes due to controller-runtime update

Copy link

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor Author

leelavg commented Dec 20, 2023

In addition to PR checks I performed below:

  1. Onboard client from this PR onto provider stable-4.14
  2. Created storageclassclaim after storageclient is connected and claims went into ready state
  3. Delete storageclassclaim and then delete storageclient

All through out the testing, I see reconciles and expected state changes.

@nb-ohad
Copy link
Contributor

nb-ohad commented Dec 20, 2023

\lgtm

@nb-ohad nb-ohad merged commit 38824f7 into red-hat-storage:main Dec 20, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants