controllers: pick next best version of csi images

[leelavg]

pick the csi sidecar images version that are best suitable for the platform

[leelavg]

/cherrypick release-4.15
fix for https://bugzilla.redhat.com/show_bug.cgi?id=2254216

[openshift-cherrypick-robot]

@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[leelavg]

/cherrypick fusion-hci-4.14

[openshift-cherrypick-robot]

@leelavg: once the present PR merges, I will cherry-pick it on top of fusion-hci-4.14 in a new PR and assign it to you.

In response to this:

/cherrypick fusion-hci-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[leelavg]

btw, below testing was done:

1. Create OCP 4.15 and deploy client-operator 4.14, picks 4.14 sidecar images
2. Update client-operator to 4.15, picks 4.15 sidecar images

[nb-ohad]

@leelavg I have added some code structure comments but I think this PR has no merit as the behaviour should already be covered by the existing mechanized. The current mechanized is supposed to take the most matching CSI version based on the mapping and if an N-1 operator is installed on an N OCP then there will be no match for N and the N-1 version should be taken even without this code

[leelavg]

@nb-ohad @Madhu-1

should already be covered by the existing mechanized.

• existing mechanism isn't covering it

As per offline discussion, the requirement seems to be selecting next best version.

However, shouldn't we have a ceiling on how farther we can go? Can that be normalized for all platform versions or any platform creates a jump point, IOW is there any criteria that OCP at X.Y can support sidecars that are lagging upto X.<?> ?

[leelavg]

The current mechanized is supposed to take the most matching CSI version based on the mapping

• done.

[leelavg]

retested

[leelavg]

retested

[leelavg]

/hold

[leelavg]

retested
/unhold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@leelavg: new pull request created: #69

In response to this:

/cherrypick release-4.15
fix for https://bugzilla.redhat.com/show_bug.cgi?id=2254216

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@leelavg: new pull request created: #70

In response to this:

/cherrypick fusion-hci-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.