[Fix] Readmit PIC addition requests when segment-state capacity is unavailable - #8
Open
morluto wants to merge 5 commits into
Open
[Fix] Readmit PIC addition requests when segment-state capacity is unavailable#8morluto wants to merge 5 commits into
morluto wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A request can satisfy the token and KV-cache budgets but still fail PIC admission when every reusable Mamba state slot is locked. The current path raises
RuntimeError, aborting the entire batch even though the affected request could be processed through normal full-prompt recomputation.Modifications
NO_TOKENwhen neither PIC admission nor full recomputation fits.This is scoped to non-RoPE PIC addition mode. Transition-mode behavior is unchanged.
Accuracy Tests
The fallback changes scheduling and admission decisions; it does not change model state calculations.
Speed Tests and Profiling
No performance claim is made. The fallback is entered only when PIC state-slot allocation cannot satisfy the request.
Test Plan
Coverage includes:
NO_TOKENwhen full recomputation also exceeds the available budget.Closes #4.