Skip to content

fix trailing comma in productization-transparency dashboard json#428

Closed
patjlm wants to merge 1 commit intoredhat-appstudio:mainfrom
patjlm:patch-1
Closed

fix trailing comma in productization-transparency dashboard json#428
patjlm wants to merge 1 commit intoredhat-appstudio:mainfrom
patjlm:patch-1

Conversation

@patjlm
Copy link
Copy Markdown

@patjlm patjlm commented Dec 4, 2024

failure to load this dashboard in grafana:

logger=provisioning.dashboard type=file name=RHTAP t=2024-12-04T12:28:48.385451243Z level=error msg="failed to load dashboard from " file=/grafana-dashboard-definitions/RHTAP/namespace_app-sre-observability-production.configmap_grafana-dashboard-productization-transparency.productization-transparency.json error="invalid character ']' looking for beginning of value"

failure to load this dashboard in grafana:

```
logger=provisioning.dashboard type=file name=RHTAP t=2024-12-04T12:28:48.385451243Z level=error msg="failed to load dashboard from " file=/grafana-dashboard-definitions/RHTAP/namespace_app-sre-observability-production.configmap_grafana-dashboard-productization-transparency.productization-transparency.json error="invalid character ']' looking for beginning of value"
```
@mftb
Copy link
Copy Markdown
Collaborator

mftb commented Dec 4, 2024

/retest

@mftb
Copy link
Copy Markdown
Collaborator

mftb commented Dec 4, 2024

Looks like you got a git-lint issue. Please fix your git message accordingly.

@mftb
Copy link
Copy Markdown
Collaborator

mftb commented Dec 4, 2024

/retest

@pacho-rh pacho-rh self-requested a review December 4, 2024 18:16
@pacho-rh
Copy link
Copy Markdown
Collaborator

Closing this PR as we had this fixed with #438

@pacho-rh pacho-rh closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants