[DO NOT MERGE] [RHTAP-5631] Changes tasks for testing purposes #1264
Conversation
WalkthroughUpdated a Tekton pipeline YAML to change the Git repository URL and revision for two tasks; PathInRepo and image references remain unchanged. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsmid1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
integration-tests/pipelines/tssc-cli-e2e.yaml (2)
149-153: Parameterize tssc test repo/revision; default to upstream/mainVerified jsmid1 fork branch RHTAP-5631 and the referenced path exist.
File: integration-tests/pipelines/tssc-cli-e2e.yaml (lines 149-153)
- - name: url - value: https://github.com/jsmid1/tssc-test.git + - name: url + value: $(params.tssc-tests-repo) - - name: revision - value: RHTAP-5631 + - name: revision + value: $(params.tssc-tests-revision)Add these pipeline params under spec.params:
- name: tssc-tests-repo description: Git repo for tssc test tasks type: string default: https://github.com/redhat-appstudio/tssc-test.git - name: tssc-tests-revision description: Git revision for tssc test tasks type: string default: main
171-175: Replace hardcoded tssc-tests repo/revision with paramsintegration-tests/pipelines/tssc-cli-e2e.yaml (lines 171-175) — verified branch RHTAP-5631 and integration-tests/tasks/tssc-ui.yaml exist in https://github.com/jsmid1/tssc-test.git. Apply this diff:
- - name: url - value: https://github.com/jsmid1/tssc-test.git + - name: url + value: $(params.tssc-tests-repo) - - name: revision - value: RHTAP-5631 + - name: revision + value: $(params.tssc-tests-revision)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
integration-tests/pipelines/tssc-cli-e2e.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / tssc-cli-on-pull-request
|
/retest |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
integration-tests/pipelines/tssc-cli-e2e.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / tssc-cli-on-pull-request
| value: https://github.com/jsmid1/tssc-test.git | ||
| - name: revision | ||
| value: main | ||
| value: RHTAP-5631 |
There was a problem hiding this comment.
Revert remote task source to trusted org repo
Pointing the Tekton git resolver at a personal fork on branch RHTAP-5631 bypasses the vetted redhat-appstudio/tssc-test code and exposes the pipeline to unreviewed remote resources—exactly the supply-chain compromise scenario Tekton’s trusted-resources model is designed to guard against.(github.com) Restore these references to the upstream organization repository (or ensure they are signed and verified before execution) before this merges.
- - name: url
- value: https://github.com/jsmid1/tssc-test.git
- - name: revision
- value: RHTAP-5631
+ - name: url
+ value: https://github.com/redhat-appstudio/tssc-test.git
+ - name: revision
+ value: mainAlso applies to: 152-154
🤖 Prompt for AI Agents
integration-tests/pipelines/tssc-cli-e2e.yaml around lines 130-132 (and also
lines 152-154): the git resolver is pointed at a personal fork and branch
(jsmid1/tssc-test, revision RHTAP-5631); replace the repository URL and revision
with the vetted upstream organization repo and appropriate trusted ref (e.g.,
github.com/redhat-appstudio/tssc-test and a stable tag/branch or commit hash),
or ensure that any external repo/branch used is cryptographically
signed/verified and referenced accordingly; update both locations (130-132 and
152-154) to reference the trusted upstream repo and trusted ref before merging.
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
|
/retest |
|
@jsmid1: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.19-27rdmTest results analysis<not enabled> OCI Artifact Browser URL<not enabled> |
This PR is for testing purposes.
Summary by CodeRabbit
Tests
Chores