Set console plugin ns dynamically #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this discussion in previous PR, Instead of using a hard coded ns for the console plugin, the plugin ns will be set according to the ns of the controller.
The controller ns is saved as an env var within the container using downward API.
That way, when setting up controller's manager and creating the plugin resources, we can extract the controller's ns and set it as the console plugin ns as well.
The plugin resources don't have a default ns, and are set with a place holder for the ns. That way, if we fail to set the operator ns as the plugins ns, will get back an error.