-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual OCP and nonOCP compatibility adjustments #491
Open
greyerof
wants to merge
15
commits into
redhat-best-practices-for-k8s:main
Choose a base branch
from
greyerof:special-dp-adjustments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dual OCP and nonOCP compatibility adjustments #491
greyerof
wants to merge
15
commits into
redhat-best-practices-for-k8s:main
from
greyerof:special-dp-adjustments
+64
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replica count set from template var to make it compatible with SNO clusters using "REPLICAS=1 make install". - Affinity rule updated to use "operator: Exists", since those labels don't have any value in real OCP clusters.
Also: - Added runAsNonRoot to securityContext of all test pods. - Moved REPLICAS env var setting to init-env.sh script. - Avoid creating file in /tmp to prepare pods to pass the readOnlyRootFilesystem check.
greyerof
changed the title
Deployment special adjustments.
Dual OCP and nonOCP compatibility adjustments
Sep 17, 2024
Everything works except for the "check results" step, where the failing check is now passing (which is the purpose of some of the modifications):
|
greyerof
force-pushed
the
special-dp-adjustments
branch
from
September 24, 2024 14:13
463a675
to
35298fb
Compare
edcdavid
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to make it compatible with SNO and OCP, but also to prepare samples for
more securityContext's fields checks.
Specific to special-dp pods:
SNO clusters.
have any value in real OCP clusters.
Other changes:
pods are deployed in Kind or Openshift. For OCP, most fields are not needed
as they're set by SCC policies, whereas in Kind they must be explicitly set.
Otherwise, some access-control test cases might fail.
readOnlyRootFilesystem check.