OCPBUGS-38284: v2 clean up subscriptions #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzding
force-pushed
the
v2-sub-cleanup
branch
6 times, most recently
from
9479470
to
ba67c5b
Compare
jzding
changed the title
jzding
requested review from
aneeshkp,
vitus133,
josephdrichard and
nishant-parekh
| numSubDeleted, err := s.subscriberAPI.DeleteAllSubscriptions() | ||
|
|
||
| // Subscriptions could be partially deleted when there were errors | ||
| if numSubDeleted > 0 { |
There was a problem hiding this comment.
This will be true when all subscriptions are deleted too right? numSubDeleted equals the number of subscriptions deleted.. you need a way to check whether the number of subscriptions before the delete == numSubDeleted? if not you can update the metrics with the difference?
There was a problem hiding this comment.
The metric simple pegs number of subs what were deleted, either all (err==nil) or some (when err!=nil).
Signed-off-by: Jack Ding <[email protected]>
jzding
added a commit
to jzding/rest-api
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Jack Ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.