Use generators where it makes sense #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diaasami
force-pushed
the
generators
branch
2 times, most recently
from
5ae110f to
a73266c
Compare
diaasami
changed the title
diaasami
changed the title
simonbaird
reviewed
Sep 24, 2025
| 'updated': issue.fields.updated, | ||
| 'description': issue.fields.description | ||
| } | ||
|
|
There was a problem hiding this comment.
(I know this is in draft, but) I think this change needs to be described in the commit message, or split into a separate commit.
There was a problem hiding this comment.
thanks for the feedback, what do you think now?
diaasami
force-pushed
the
generators
branch
from
a73266c to
3ca1eb6
Compare
diaasami
force-pushed
the
generators
branch
2 times, most recently
from
e88abbc to
5f1b9d7
Compare
for clarity and modularity
It's only used in cases where there is significant copying and big objects, in other cases list comprehensions are fine
diaasami
force-pushed
the
generators
branch
from
5f1b9d7 to
68d3f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since data is accessed once and there's no need to keep it in memory