Skip to content

fix settings not merged#47

Merged
djdanielsson merged 2 commits intoredhat-cop:mainfrom
laurent-indermuehle:lie_fix46_settings_not_merged
Feb 19, 2024
Merged

fix settings not merged#47
djdanielsson merged 2 commits intoredhat-cop:mainfrom
laurent-indermuehle:lie_fix46_settings_not_merged

Conversation

@laurent-indermuehle
Copy link
Copy Markdown
Contributor

fix #46

I'm not sure we can use list_merge with recursive together. Or can we?

@j-random-geek
Copy link
Copy Markdown

I had the same issue and did the same thing to make the settings work in my environment (2 AAP installs - one VM-based, one containerized). Seems to work as expected for me.

@djdanielsson
Copy link
Copy Markdown
Collaborator

Did you leave the append or replace it with recursive? @j-random-geek

@j-random-geek
Copy link
Copy Markdown

Did you leave the append or replace it with recursive? @j-random-geek

Sorry, I missed that. I left in the append - this is what's in my own (different environment names, obviously):

controller_settings: '{{ controller_settings_all | ansible.builtin.combine(controller_settings_vm, list_merge="append", recursive=true) }}'

@laurent-indermuehle
Copy link
Copy Markdown
Contributor Author

Great, thanks for your addition @j-random-geek. I'm on vacations for one week. I'll commit this change when I'm back.

I removed it in a previous commit because I didn't knew we can use both
list_merge and recursive.
@laurent-indermuehle
Copy link
Copy Markdown
Contributor Author

@djdanielsson I tested to use both list_append and recursive and it seems to work. Thanks @j-random-geek!
I added back list_append to this PR.

Copy link
Copy Markdown
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 1a089a2 into redhat-cop:main Feb 19, 2024
@laurent-indermuehle laurent-indermuehle deleted the lie_fix46_settings_not_merged branch March 1, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

settings are not merged between all and env

3 participants