Fix SSH config from cloud-init: rm line about PasswordAuthentication (#…

…7518)

* cloud-init: rm line about PasswordAuthentication

Remove the configuration that forbids PasswordAuthentication in Cloud
init ssh file:

[root@bastion sshd_config.d]# cat /etc/ssh/sshd_config.d/50-cloud-init.conf
PasswordAuthentication no

Don't delete the file but use lineinfile module to remove only that
line, as that file may be used for other puprose later.

* Patch rosa config too

ansible/configs/rosa-consolidated/pre_software.yml

@@ -45,11 +45,12 @@
       regexp: '^ *PasswordAuthentication'
       path: /etc/ssh/sshd_config
 
-  - name: Remove 50-cloud-init.conf
+  - name: Remove PasswordAuthentication line from 50-cloud-init.conf
     when: bastion_remove_cloud_init_conf | default(true) | bool
-    ansible.builtin.file:
-      state: absent
+    ansible.builtin.lineinfile:
       path: /etc/ssh/sshd_config.d/50-cloud-init.conf
+      regexp: PasswordAuthentication
+      state: absent
 
   - name: Restart sshd
     ansible.builtin.service:

ansible/roles/bastion-student-user/tasks/main.yml

@@ -54,6 +54,13 @@
     regexp: '^ *PasswordAuthentication'
     path: /etc/ssh/sshd_config
 
+- name: Remove PasswordAuthentication line from 50-cloud-init.conf
+  when: bastion_remove_cloud_init_conf | default(true) | bool
+  ansible.builtin.lineinfile:
+    path: /etc/ssh/sshd_config.d/50-cloud-init.conf
+    regexp: PasswordAuthentication
+    state: absent
+
 - name: Disable root password authentication
   lineinfile:
     line: PermitRootLogin without-password