Fix Windows node deployment for OCP 4.18+ #9626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Windows AMI filter from Server 2019 to Server 2022 - Add security group resolution to prevent 'no security group found' errors - Query AWS for actual security group ID instead of relying on tag filters - Use resolved SG ID in Windows MachineSet template with fallback Fixes compatibility with OpenShift 4.18+ which requires Windows Server 2022. Resolves security group lookup failures from previous 4.16 upgrade attempts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix Windows node deployment for OCP 4.18+ compatibility:
Note: Please merge to development branch only for testing. Do not deploy to production until dev validation is complete.
ISSUE TYPE
COMPONENT NAME
ocp4_workload_windows_node
ADDITIONAL INFORMATION
Files changed: defaults/main.yml, tasks/workload.yml, templates/windows-ms.j2
Before:
Error: "error getting security groups IDs: no security group found"
Windows AMI: Windows_Server-2019
After:
Security group resolved via AWS query
Windows AMI: Windows_Server-2022