Simple proxy detection support #1404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
==========================================
- Coverage 92.57% 91.87% -0.71%
==========================================
Files 47 47
Lines 4929 5021 +92
Branches 551 871 +320
==========================================
+ Hits 4563 4613 +50
- Misses 366 373 +7
- Partials 0 35 +35
Continue to review full report at Codecov.
|
|
test this |
jrichter1
requested changes
Apr 26, 2018
browser/services/request.js
Outdated
| if(this.electron) { | ||
| this.electron.remote.getCurrentWindow().webContents.session.resolveProxy("https://google.com", function(p){ | ||
| //parse PROXY XXX.XXX.XXX.XXX:XXXX; | ||
| let proxy = p.replace(/(PROXY|DIRECT)/g,'').replace(/;/g,'').replace(/ /g,''); |
There was a problem hiding this comment.
Could you merge these replace calls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.