Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Updated 07-remove-managed-by & added 03-errors for 1-083_validate_apps_in_any_namespace kuttl test #542

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Jun 16, 2023

Signed off: @ciiay
What type of PR is this?
/kind failing-test

What does this PR do / why we need it:
For GITOPS-2874 which is a blocker to our test-automation.

Which issue(s) this PR fixes:

Fixes #?
Flaky test 1-083_validate_apps_in_any_namespace

How to test changes / Special notes to the reviewer:
The main change of this PR is I updated the way to remove managed-by label with the declarative YAML approach which often results in more immediate reconciliation. In this way, we don't have to restart the application-controller anymore.

This PR works along with argocd-operator PR #934.

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Jun 16, 2023
@ciiay ciiay changed the title Updated 07-remove-managed-by & added 03-errors test: Updated 07-remove-managed-by & added 03-errors for 1-083_validate_apps_in_any_namespace kuttl test Jun 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anandf for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

@ciiay: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.12-kuttl-parallel 570a16c link true /test v4.12-kuttl-parallel
ci/prow/v4.10-kuttl-sequential 570a16c link true /test v4.10-kuttl-sequential
ci/prow/v4.11-kuttl-sequential 570a16c link true /test v4.11-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ciiay
Copy link
Contributor Author

ciiay commented Jul 12, 2023

This PR was created to fix flaky kuttl tests which block ci check of argocd-operator PR #934. Now that the original argocd-operator PR #934 has been closed, closing this PR as well.

@ciiay ciiay closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a frequently failing test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant