Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky e2e tests #557

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented Jul 10, 2023

What type of PR is this?
/kind failing-test

What does this PR do / why we need it:
This PR disables flaky e2e tests to unblock tide PR merges by moving them to test/openshift/e2e/ignore-tests/ folder. These test failures are addressed in separate PRs and will be enabled again in those PRs.

Test Issue PR to fix test
1-004_validate_argocd_installation
1-005_validate_metrics
1-006_validate_machine_config GITOPS-2844
1-010_validate-ootb-manage-other-namespace GITOPS-2997
1-018_validate_disable_default_instance GITOPS-2829 #540
1-027_validate_operand_from_git GITOPS-2838
1-031_validate_toolchain
1-035_validate_argocd_secret_repopulate GITOPS-2998 #543
1-042_validate_status_host GITOPS-2985 #530
1-064_validate_tcp_reset_error GITOPS-3078 #561
1-083_validate_apps_in_any_namespace GITOPS-2874 argoproj-labs/argocd-operator#939
parallel/1-009_validate-manage-other-namespace GITOPS-2826
parallel/1-055_validate_notification_controller GITOPS-2857
parallel/1-057_validate_notifications GITOPS-3076
parallel/1-068_validate_redis_secure_comm_autotls_no_ha GITOPS-3077

Signed-off-by: Siddhesh Ghadi <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Jul 10, 2023
@svghadi svghadi marked this pull request as ready for review July 10, 2023 13:23
@svghadi svghadi marked this pull request as draft July 10, 2023 13:24
@varshab1210
Copy link
Member

Hi @svghadi, I have raised PRs for fixing 1-042_validate_status_host and 1-035_validate_argocd_secret_repopulate could you please take a look? Hopefully it'll fix them.

#530
#545

@ciiay
Copy link
Contributor

ciiay commented Jul 11, 2023

@svghadi I also have a PR for 1-083_validate_apps_in_any_namespace fix, could you please take a look too?
argoproj-labs/argocd-operator#939

Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi svghadi marked this pull request as ready for review July 12, 2023 09:49
@svghadi svghadi requested review from iam-veeramalla and varshab1210 and removed request for anandrkskd and trdoyle81 July 12, 2023 09:54
@svghadi
Copy link
Member Author

svghadi commented Jul 12, 2023

/retest

@svghadi
Copy link
Member Author

svghadi commented Jul 12, 2023

/test all

1 similar comment
@svghadi
Copy link
Member Author

svghadi commented Jul 12, 2023

/test all

@iam-veeramalla
Copy link
Collaborator

great work @svghadi

@iam-veeramalla
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2236309 into redhat-developer:master Jul 12, 2023
@svghadi svghadi deleted the disable-tests branch July 12, 2023 14:14
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
* Disable flaky e2e tests

Signed-off-by: Siddhesh Ghadi <[email protected]>

* Disable 1-057_validate_notifications

Signed-off-by: Siddhesh Ghadi <[email protected]>

* Disable 1-068_validate_redis_secure_comm_autotls_no_ha

Signed-off-by: Siddhesh Ghadi <[email protected]>

* Disable flaky tests

Signed-off-by: Siddhesh Ghadi <[email protected]>

* Disable test

Signed-off-by: Siddhesh Ghadi <[email protected]>

---------

Signed-off-by: Siddhesh Ghadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/failing-test Categorizes issue or PR as related to a frequently failing test. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants