Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding new environment variable for rollouts #781

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jparsai
Copy link
Collaborator

@jparsai jparsai commented Oct 1, 2024

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This PR is to set value for environment variable CLUSTER_SCOPED_ARGO_ROLLOUTS_NAMESPACES for rollouts controller while installing operator. This value will be used by rollouts manager repo. Here is the PR that will use values provided argoproj-labs/argo-rollouts-manager#95

Copy link

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jaideepr97 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jparsai jparsai force-pushed the new-env branch 3 times, most recently from e2c237c to 9ad8d8d Compare October 1, 2024 14:33
@jparsai
Copy link
Collaborator Author

jparsai commented Oct 1, 2024

/test v4.14-kuttl-parallel

@jgwest
Copy link
Collaborator

jgwest commented Oct 2, 2024

/retest

Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jparsai!

@jgwest jgwest merged commit 6687435 into redhat-developer:master Oct 2, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants