Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tkn image set in makefile #283

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

lilyLuLiu
Copy link
Collaborator

@lilyLuLiu lilyLuLiu commented Sep 2, 2024

@anjannath
Copy link
Collaborator

LGTM

so when we want to now push a released 8.0.0 image we can use, e.g make VERSION=8.0.0 tkn-push

tkn/infra-aws-mac.yaml Outdated Show resolved Hide resolved
@adrianriobo
Copy link
Collaborator

Also I notice the tkn-bundle/tkn-check passed but that should not be the case, as the spec do not contain a valid image on it, it just contains the <IMAGE> field as the tkn-template is not being used there.

We have to issues there:

  • Ensure the template function is used somehow before they are deployed to the cluster on the check
  • Look for a way to dry/run or some type of test which may does not require credentials / or something we can pass empty to test the task will be able to run.

@lilyLuLiu
Copy link
Collaborator Author

@adrianriobo , I keep the orignal tkn yaml files and use another folder to store the templates. So tkn-bundle/tkn-check can check the validation of the tkn file. Also add make tkn-update in makefile for updating the version for tkn.

@adrianriobo adrianriobo merged commit 0de1c03 into redhat-developer:main Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants