-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add parameter cleanup-state #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add parameter cleanup-state #671
Conversation
|
Sample output for directory that was already succefully removed in the past |
adrianriobo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it would nice have it true as default?
Also can you expand it to other actions on AWS?
Also can you create a following issue pointing to this one to match this logic on Azure?
|
True as default value would make it a breaking change. Personally, I would prefer running this in production for a week or two and then expanding it to other actions in AWS and possible also making it default behavior. If you really want to do it in this PR, I can add it 🤷🏻 |
|
mmm being under 1.0.0 version allow us to do it, and that request has been triggered multiple times.. but if you prefer to test it for a while first I am fine, just create the following to recall to change it to true for version |
Parameter that adds option to remove Pulumi state files from S3 bucket for all AWS commands. Enabled by default. Closes redhat-developer#639 Signed-off-by: Pavol Pitonak <[email protected]>
62d6bbd to
1a9d2ba
Compare
|
Fair point, I enabled it by default and implemented it in all other AWS commands. Created the same issue for Azure #674 |
|
Do you want to translate it into Tekton tasks? |
|
Yes, but in a separate PR, this is already big (21 changed files) |
adrianriobo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Optionally remove Pulumi state files from S3 bucket for RHEL and RHEL AI Closes #639