test(e2e): adjust selectors for rbac test #2155
Conversation
nilgaar
changed the title
|
The image is available at: |
|
The image is available at: |
| let nextButton2: Locator; | ||
| do { | ||
| nextButton2 = page.getByTestId("nextButton-2"); | ||
| } while (nextButton2.all.length > 1); |
There was a problem hiding this comment.
This could be Infinite Loop if nextButton2's length never decreases to 1
There was a problem hiding this comment.
may be you can use page.waitForFunction()
There was a problem hiding this comment.
anyway I guess it would be timedout so doesn't matter.
There was a problem hiding this comment.
thank you Subhash for taking a look at it. I did a fix that uses attempts too.
As the e2e are not running, I had to put the PR on hold...
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
@nilgaar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
New changes are detected. LGTM label has been removed. |
|
/test all |
|
@nilgaar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The image is available at: |
|
/hold |
|
The image is available at: |
|
/test all |
|
@nilgaar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
a race condition made a e2e rbac test fail from time to time
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer