Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): enable scaffolder processor for GKE and AKS tests #2166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PatAKnight
Copy link
Member

Description

Verify Scaffolded link in components Dependencies and scaffoldedFrom relation in entity Raw Yaml tests are failing for nightly GKE and AKS. Seems like at some point the plugin was disabled and never re-enabled. This is causing the tests to fail as the label that comes from the backstage-community-plugin-catalog-backend-module-scaffolder-relation-processor-dynamic is not present.

This PR enables the plugin so that the tests will pass again.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from josephca and psrna January 9, 2025 13:32
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Copy link
Contributor

github-actions bot commented Jan 9, 2025

@PatAKnight PatAKnight force-pushed the relation-processor-aks-gke branch from 66c2c9e to dabcbb2 Compare January 10, 2025 13:27
Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pataknight. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copy link

openshift-ci bot commented Jan 10, 2025

@PatAKnight: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests dabcbb2 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant