chore: remove the dynamic-plugins.default.yaml

[nickboldt]

What does this PR do?

chore: remove the dynamic-plugins.default.yaml from main branch of RHDH repo, as we are now generating it as part of the plugin catalog's index image build: https://gitlab.cee.redhat.com/rhidp/rhdh-plugin-catalog/-/blob/rhdh-1-rhel-9/catalog-index/dynamic-plugins.default.yaml using default.packages.yaml + package metadata in the overlays repo (RHIDP-9835)

Signed-off-by: Nick Boldt [email protected]

What issues does this PR fix or reference?

RHIDP-9863

How to test this PR?

This is a BREAKING CHANGE.

Any process that depends on the DPDY file (dynamic-plugins.default.yaml) being in this repo needs to be adapted to consume the https://quay.io/rhdh/plugin-catalog-index from the appropriate RHDH version tag (eg., :1.9)

You can extract the file like this:

TAG="1.9" # or a  specific build like 1.9-5
DIR="/tmp/plugin-catalog-index_${TAG}"
mkdir -p "$DIR"
container_id=$(podman create "quay.io/rhdh/plugin-catalog-index:${TAG}")
podman export $container_id -o /tmp/image.tar && tar xf /tmp/image.tar -C "${DIR}/"
podman rm $container_id; rm -f /tmp/image.tar

The file is therefore in "${DIR}/dynamic-plugins.default.yaml"

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 04kash for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@nickboldt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm	dc6e2fe	link	true	/test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[nickboldt]

14 places in this repo that refer to the DPDY file (with line numbers):

** [1] ./.cursor/rules/add_extension_metadata.mdc **
96:# Generate package metadata from dynamic-plugins.default.yaml
99:  -p dynamic-plugins.default.yaml \

** [2] ./docker/Dockerfile **
175:COPY $EXTERNAL_SOURCE_NESTED/dynamic-plugins.default.yaml ./

** [3] ./docker/install-dynamic-plugins.py **
64:      - dynamic-plugins.default.yaml

** [4] ./docs/dynamic-plugins/installing-plugins.md **
19:The RHDH container image is preloaded with a variety of dynamic plugins, the majority of which are initially disabled due to mandatory configuration requirements. The comprehensive list of these plugins is outlined in the [`dynamic-plugins.default.yaml`](https://github.com/redhat-developer/rhdh/blob/main/dynamic-plugins.default.yaml) file.
35:While the plugin's default configuration comes from the `dynamic-plugins.default.yaml` file, you still have the option to override it by incorporating a `pluginConfig` entry into the plugin configuration.
77:When working with OCI-packaged dynamic plugins, you may want to avoid specifying the version (tag or digest) in multiple places, especially when including plugins from other configuration files such as `dynamic-plugins.default.yaml`. Setting the tag of the OCI package to `{{inherit}}` allows a plugin configuration override to inherit the plugin version from an included configuration.

** [5] ./docs/index.md **
59:      - dynamic-plugins.default.yaml
67:By default, the `analytics-provider-segment` plugin is disabled when you run your application locally without using the `dynamic-plugins.default.yaml` file.
68:However, if you run your application using the `dynamic-plugins.default.yaml` file, you can disable the `analytics-provider-segment` plugin as shown in the following example:
115:      - dynamic-plugins.default.yaml

** [6] ./dynamic-plugins/_utils/src/wrappers.test.ts **
13:  "dynamic-plugins.default.yaml",
202:  describe("(dynamic-plugins.default.yaml) should have a valid config", () => {

** [7] ./e2e-tests/playwright/utils/authentication-providers/yamls/dynamic-plugins-config.yaml **
2:  - dynamic-plugins.default.yaml

** [8] ./.ibm/pipelines/resources/postgres-db/values-showcase-postgres.yaml **
4:      - dynamic-plugins.default.yaml

** [9] ./.ibm/pipelines/value_files/values_showcase-auth-providers.yaml **
4:      - dynamic-plugins.default.yaml

** [10] ./.ibm/pipelines/value_files/values_showcase-rbac.yaml **
8:      - "dynamic-plugins.default.yaml"

** [11] ./.ibm/pipelines/value_files/values_showcase.yaml **
8:      - "dynamic-plugins.default.yaml"

** [12] ./.rhdh/docker/Dockerfile **
193:COPY $EXTERNAL_SOURCE_NESTED/dynamic-plugins.default.yaml ./

** [13] ./scripts/rhdh-openshift-setup/values.yaml **
8:      - 'dynamic-plugins.default.yaml'

** [14] ./turbo.json **
11:    "dynamic-plugins.default.yaml"

So becasue carving this file out is far from simple, I've set this PR back to draft. Will need help from others here.

[github-actions]

The image is available at:

• quay.io/rhdh-community/rhdh:pr-3711
• quay.io/rhdh-community/rhdh:pr-3711-adb0a95e

[kadel]

Quick suggestion on what we can do with those references.
It needs more investigation, this is just my quick take just based on the location

** [1] ./.cursor/rules/add_extension_metadata.mdc **
96:# Generate package metadata from dynamic-plugins.default.yaml
99: -p dynamic-plugins.default.yaml \

we can probably remove this whole role, as it doesn't make sense anymore in this repo.
We can later update it and move it to overlay repo.

** [2] ./docker/Dockerfile **
175:COPY $EXTERNAL_SOURCE_NESTED/dynamic-plugins.default.yaml ./

this line can be removed

** [3] ./docker/install-dynamic-plugins.py **
64: - dynamic-plugins.default.yaml

this should stay

** [4] ./docs/dynamic-plugins/installing-plugins.md **
19:The RHDH container image is preloaded with a variety of dynamic plugins, the majority of which are initially disabled due to mandatory configuration requirements. The comprehensive list of these plugins is outlined in the dynamic-plugins.default.yaml file.
35:While the plugin's default configuration comes from the dynamic-plugins.default.yaml file, you still have the option to override it by incorporating a pluginConfig entry into the plugin configuration.
77:When working with OCI-packaged dynamic plugins, you may want to avoid specifying the version (tag or digest) in multiple places, especially when including plugins from other configuration files such as dynamic-plugins.default.yaml. Setting the tag of the OCI package to {{inherit}} allows a plugin configuration override to inherit the plugin version from an included configuration.

** [5] ./docs/index.md **
59: - dynamic-plugins.default.yaml
67:By default, the analytics-provider-segment plugin is disabled when you run your application locally without using the dynamic-plugins.default.yaml file.
68:However, if you run your application using the dynamic-plugins.default.yaml file, you can disable the analytics-provider-segment plugin as shown in the following example:
115: - dynamic-plugins.default.yaml

docs will have to be updated

** [6] ./dynamic-plugins/_utils/src/wrappers.test.ts **
13: "dynamic-plugins.default.yaml",
202: describe("(dynamic-plugins.default.yaml) should have a valid config", () => {

** [7] ./e2e-tests/playwright/utils/authentication-providers/yamls/dynamic-plugins-config.yaml **
2: - dynamic-plugins.default.yaml

** [8] ./.ibm/pipelines/resources/postgres-db/values-showcase-postgres.yaml **
4: - dynamic-plugins.default.yaml

** [9] ./.ibm/pipelines/value_files/values_showcase-auth-providers.yaml **
4: - dynamic-plugins.default.yaml

** [10] ./.ibm/pipelines/value_files/values_showcase-rbac.yaml **
8: - "dynamic-plugins.default.yaml"

** [11] ./.ibm/pipelines/value_files/values_showcase.yaml **
8: - "dynamic-plugins.default.yaml"

depending on the test case, this should be either updated or maybe keep it as it is, it will require further analysis

** [12] ./.rhdh/docker/Dockerfile **
193:COPY $EXTERNAL_SOURCE_NESTED/dynamic-plugins.default.yaml ./

this line can be removed

** [13] ./scripts/rhdh-openshift-setup/values.yaml **
8: - 'dynamic-plugins.default.yaml'

not sure where this is used, probably for testing, it should probably stay as it is

** [14] ./turbo.json **
11: "dynamic-plugins.default.yaml"

this line can be removed

[kadel]

/hold

This PR should not be merged before we have the new dynamic-plugin.defualt.yaml generation/extraction process in place

[github-actions]

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.