-
Notifications
You must be signed in to change notification settings - Fork 211
fix(RHIDP-8971): migrate tests to use extensions catalog entities from overlay repo #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9d56412 to
a9b4ef6
Compare
|
/retest |
a9b4ef6 to
9729237
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9729237 to
2684ad7
Compare
|
/test e2e-ocp-helm |
|
@sanketpathak: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # RHIDP-5216/RHIDP-5215 - interim marketplace catalog entities until these data will be loaded from container images | ||
| COPY $EXTERNAL_SOURCE_NESTED/catalog-entities/marketplace /marketplace/catalog-entities/ | ||
| # Extract marketplace catalog entities from the new index image | ||
| FROM quay.io/rhdh/plugin-catalog-index:1.9.0 AS catalog-index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a scratch image, so you can't just reference it this way
| FROM runner AS final | ||
|
|
||
| # Copy catalog entities from the index image instead of local files | ||
| COPY --from=catalog-index /catalog-entities/marketplace /opt/app-root/src/marketplace/catalog-entities/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because quay.io/rhdh/plugin-catalog-index are scratch images (with no OS) you can't just pull the image and mount it to get file paths. You have to extract the contents.
See https://gist.github.com/nickboldt/86f78312234d84490f1186b389235a29#file-unpack-oci-sh-L5-L7 for how to fetch, unpack, and access the files you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this in the related JIRA some weeks ago https://issues.redhat.com/browse/RHIDP-8971?focusedId=28473233&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28473233
nickboldt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach here is wrong.
We do NOT want to continue to embed the catalog entities in the RHDH image. That was why we moved them into a separate container image.
The ask in https://issues.redhat.com/browse/RHIDP-8971 was to have the tests use the NEW location of the catalog index image, not to re-embed the contents back into the RHDH image.
See also https://issues.redhat.com/browse/RHIDP-9764 and https://issues.redhat.com/browse/RHIDP-9762 where we're adding the ability for the helm and operator to deploy the index image at install time.
Description
https://issues.redhat.com/browse/RHIDP-8971
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer