Skip to content

feat: add support for multiple auth providers in signInPage #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kim-tsao merged 4 commits into from
Dec 12, 2025
Merged

feat: add support for multiple auth providers in signInPage #3818

kim-tsao merged 4 commits into from
Dec 12, 2025

Conversation

@JessicaJHee
Copy link
Member

@JessicaJHee JessicaJHee commented Dec 8, 2025

Description

Enables the ability to list multiple auth providers in the app-config to allow authentication with multiple auth providers.

This is the sign-in page with the following config applied:

signInPage:
  - github
  - microsoft
  - oidc
  - github
image

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@JessicaJHee JessicaJHee requested a review from gashcrumb December 8, 2025 16:56
@openshift-ci openshift-ci bot requested review from PatAKnight and rm3l December 8, 2025 16:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

The image is available at:

karthikjeeyar
karthikjeeyar reviewed Dec 9, 2025
View reviewed changes
Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JessicaJHee Changes looks good to me 🎉

multiple-auth-providers

Can you please update the SignInPage configuration documentation with the multiple auth providers support?

HusneShabbir
HusneShabbir reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
works as expected
Screenshot 2025-12-09 at 12 53 26 PM

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2025
@JessicaJHee JessicaJHee force-pushed the multiple-signinpage-config branch from 9190441 to 1001d19 Compare December 9, 2025 16:31
@openshift-ci openshift-ci bot removed the lgtm label Dec 9, 2025
@JessicaJHee
Copy link
Member Author

JessicaJHee commented Dec 9, 2025

@karthikjeeyar Thanks for the review! I've added the docs, PTAL :)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

The image is available at:

karthikjeeyar
karthikjeeyar approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2025
gashcrumb
gashcrumb reviewed Dec 10, 2025
View reviewed changes
gashcrumb
gashcrumb approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'd suggest to just sort the one sonarcloud warning.

@JessicaJHee JessicaJHee force-pushed the multiple-signinpage-config branch from 1001d19 to 9f74093 Compare December 10, 2025 17:04
@openshift-ci openshift-ci bot removed the lgtm label Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Dec 10, 2025

/test e2e-ocp-helm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

The image is available at:

@kim-tsao
Copy link
Member

kim-tsao commented Dec 11, 2025

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Dec 11, 2025

/retest

Zaperex
Zaperex reviewed Dec 11, 2025
View reviewed changes
@JessicaJHee @Zaperex
Update docs/auth.md
0b64789 
Co-authored-by: Frank Kong <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

The image is available at:

@kim-tsao
Copy link
Member

kim-tsao commented Dec 12, 2025

/override ci/prow/e2e-ocp-helm

@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2025

@kim-tsao: Overrode contexts on behalf of kim-tsao: ci/prow/e2e-ocp-helm

In response to this:

/override ci/prow/e2e-ocp-helm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kim-tsao
Copy link
Member

kim-tsao commented Dec 12, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb, HusneShabbir, karthikjeeyar, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit a2328bf into redhat-developer:main Dec 12, 2025
17 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2025

@JessicaJHee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 0b64789 link unknown /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zaperex Zaperex Zaperex left review comments

@gashcrumb gashcrumb gashcrumb approved these changes

@kim-tsao kim-tsao kim-tsao approved these changes

@PatAKnight PatAKnight Awaiting requested review from PatAKnight

@rm3l rm3l Awaiting requested review from rm3l

+2 more reviewers

@HusneShabbir HusneShabbir HusneShabbir left review comments

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthikjeeyar karthikjeeyar

@kim-tsao kim-tsao

@HusneShabbir HusneShabbir

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JessicaJHee @kim-tsao @gashcrumb @karthikjeeyar @Zaperex @HusneShabbir