Skip to content

Conversation

@kim-tsao
Copy link
Member

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?
  • Update prettier to fix errors in this Renovate PR

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@rhdh-qodo-merge
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Issue

Using Array.prototype.filter with an async predicate returns an array of unresolved Promises/truthy values rather than filtering by the awaited condition; consider using Promise.all with map + filter or a for..of to build the filtered list.

const realComponents: string[] = reposNames.filter(
  async (repo) =>
    await githubApi.fileExistsOnRepo(
      `${testOrganization}/${repo}`,
      CATALOG_FILE,
    ),
);
Flaky Timeout

test.setTimeout(150000 + testInfo.retry * 30000) adjusts timeout per-retry which can mask latency issues; consider explicit waits for specific conditions or increasing deterministic waits for known slow operations instead.

await catalog.goToBackstageJanusProject();
await uiHelper.clickTab("Topology");
📄 References
  1. redhat-developer/rhdh-chart/charts/backstage/values.schema.tmpl.json [199-305]
  2. redhat-developer/rhdh-chart/charts/orchestrator-infra/values.schema.json [1-133]
  3. redhat-developer/rhdh-chart/charts/orchestrator-infra/values.schema.tmpl.json [1-136]
  4. redhat-developer/rhdh-chart/charts/backstage/values.schema.tmpl.json [1-108]

@rhdh-qodo-merge
Copy link

Label

dependencies


PR Type

Enhancement


Description

  • Update Prettier from v3.6.2 to v3.7.4 across all package.json files

  • Reformat test files to comply with new Prettier v3.7.4 formatting rules

  • Adjust indentation and line wrapping in multiple e2e test specifications


File Walkthrough

Relevant files
Dependencies
8 files
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
package.json
Update Prettier dependency to v3.7.4                                         
+1/-1     
Formatting
6 files
microsoft.spec.ts
Reformat test code with Prettier v3.7.4 formatting             
+30/-33 
github-discovery.spec.ts
Reformat test code with Prettier v3.7.4 formatting             
+21/-23 
github-happy-path.spec.ts
Reformat test code with Prettier v3.7.4 formatting             
+23/-32 
bulk-import.spec.ts
Reformat test code with Prettier v3.7.4 formatting             
+30/-36 
rbac.spec.ts
Reformat test code with Prettier v3.7.4 formatting             
+25/-28 
topology.spec.ts
Reformat test code with Prettier v3.7.4 formatting             
+67/-70 

@rhdh-qodo-merge
Copy link

rhdh-qodo-merge bot commented Dec 10, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix incorrect use of async filter

Refactor the asynchronous filter to correctly identify repositories with a
CATALOG_FILE. The current implementation using async inside filter is buggy; it
should be replaced by mapping to promises, resolving them with Promise.all, and
then filtering based on the results.

e2e-tests/playwright/e2e/github-discovery.spec.ts [40-46]

-const realComponents: string[] = reposNames.filter(
-  async (repo) =>
-    await githubApi.fileExistsOnRepo(
+const existenceChecks = await Promise.all(
+  reposNames.map(repo =>
+    githubApi.fileExistsOnRepo(
       `${testOrganization}/${repo}`,
       CATALOG_FILE,
     ),
+  ),
+);
+const realComponents: string[] = reposNames.filter(
+  (_, index) => existenceChecks[index],
 );
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies a critical logic bug where an async function is improperly used within Array.prototype.filter, rendering the filter ineffective. The proposed fix using Promise.all is the correct pattern for asynchronous filtering.

Medium
  • Update

@github-actions
Copy link
Contributor

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

@gustavolira
Copy link
Member

/approve
/lgtm

Copy link
Member

@alizard0 alizard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alizard0, gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d31c17d into redhat-developer:main Dec 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants