Added Content-Security-Policy meta tags to webviews #4194
Merged
+125
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Fred Bricon <[email protected]>
|
Works fine. I added the extension icon to the webview, to be consistent with the other webviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all: had to relax the restrictions a bit for "change method signature" because the vscode webview ui toolkit adds style tags programmatically.
Fixes #4193
How to test: make sure the "Java Dashboard" and the "Change Method Signature" refactoring UI's work properly and styling and codicons show up correctly. In order to properly test, one should build a vsix version (
vsce package) and install that.