Update flags for jdt-javac #4198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to double check that I've got all the correct flags still before this is ready for review. Hopefully I'll get that done first thing tomorrow |
datho7561
force-pushed
the
update-flags-for-jdt-javac
branch
from
ac31b4f to
9bc69a2
Compare
Update the flags to match https://github.com/eclipse-jdtls/eclipse-jdt-core-incubator/blob/dom-with-javac/org.eclipse.jdt.core.javac/META-INF/p2.inf This opens a bunch of jdk internals that the jdt-javac work uses, and also sets the flags to enable the javac-based search. Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
update-flags-for-jdt-javac
branch
from
9bc69a2 to
ebbc428
Compare
|
Is completion flag |
|
Yes, there's a separate setting to enable it: https://github.com/redhat-developer/vscode-java/blob/main/src/javaServerStarter.ts#L165 |
mickaelistria
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the flags to match https://github.com/eclipse-jdtls/eclipse-jdt-core-incubator/blob/dom-with-javac/org.eclipse.jdt.core.javac/META-INF/p2.inf (I've reordered some flags to match that file).
This opens a bunch of jdk internals that the jdt-javac work uses, and also sets the flags to enable the javac-based search.