This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
Make sure the webhook preserves existing resource requests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g new ones. This commit also adds relevant tests and removes the other broken ones (probably result of a copy / paste). Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding requested resources from the pod network to the first container, the webhook currently wipes out any previous request on the pod definition.
This PR builds the patch request maintaining the current resources, so they do not get lost.
I also added relevant tests to the test file deleting it's previous content, which I suspect was the one from https://github.com/openshift/multus-admission-controller (it contained ValidateHandler invocations)