Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auto testing #21

Merged
merged 11 commits into from
May 31, 2024
Merged

Feature/auto testing #21

merged 11 commits into from
May 31, 2024

Conversation

rbs333
Copy link
Collaborator

@rbs333 rbs333 commented May 28, 2024

PR contents:

  • adds .github/workflows/tests.yml which executes on push to main and pull_request
  • test uses nbval as opposed to treon. Nbval build into pytest and allows you to skip certain cells easily which is advantageous for testing environment.
  • style tweaks to notebooks discovered while testing

this is a basic v1 to get us moving with testing on these notebooks to make sure they remain up to date and we can catch if something goes stale.

Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, otherwise looking good.

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label May 29, 2024
Copy link
Contributor

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start to cleaning up our notebooks.

@rbs333 rbs333 merged commit 4660ff0 into main May 31, 2024
1 check passed
@rbs333 rbs333 deleted the feature/auto-testing branch May 31, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants