Skip to content

Commit

Permalink
TS warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
shacharPash committed Sep 11, 2023
1 parent 0c0910e commit af1b585
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 8 deletions.
12 changes: 12 additions & 0 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"version": 1,
"isRoot": true,
"tools": {
"csharpier": {
"version": "0.25.0",
"commands": [
"dotnet-csharpier"
]
}
}
}
2 changes: 1 addition & 1 deletion src/NRedisStack/TimeSeries/DataTypes/TimeStamp.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public static implicit operator long(TimeStamp ts) =>
/// Implicit cast from TimeStamp to string.
/// </summary>
/// <param name="ts">TimeStamp</param>
public static implicit operator string(TimeStamp ts) => ts.Value.ToString();
public static implicit operator string? (TimeStamp ts) => ts.Value.ToString();

/// <summary>
/// Implicit cast from DateTime to TimeStamp.
Expand Down
6 changes: 3 additions & 3 deletions src/NRedisStack/TimeSeries/TimeSeriesAux.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static void AddChunkSize(this IList<object> args, long? chunkSize)
}
}

public static void AddLabels(this IList<object> args, IReadOnlyCollection<TimeSeriesLabel> labels)
public static void AddLabels(this IList<object> args, IReadOnlyCollection<TimeSeriesLabel>? labels)
{
if (labels != null)
{
Expand Down Expand Up @@ -215,7 +215,7 @@ public static void AddRule(this IList<object> args, TimeSeriesRule rule)
args.Add(rule.TimeBucket);
}

public static List<object> BuildTsCreateArgs(string key, long? retentionTime, IReadOnlyCollection<TimeSeriesLabel> labels, bool? uncompressed,
public static List<object> BuildTsCreateArgs(string key, long? retentionTime, IReadOnlyCollection<TimeSeriesLabel>? labels, bool? uncompressed,
long? chunkSizeBytes, TsDuplicatePolicy? policy)
{
var args = new List<object> { key };
Expand All @@ -239,7 +239,7 @@ public static List<object> BuildTsAlterArgs(string key, long? retentionTime, lon
}

public static List<object> BuildTsAddArgs(string key, TimeStamp timestamp, double value, long? retentionTime,
IReadOnlyCollection<TimeSeriesLabel> labels, bool? uncompressed, long? chunkSizeBytes, TsDuplicatePolicy? policy)
IReadOnlyCollection<TimeSeriesLabel>? labels, bool? uncompressed, long? chunkSizeBytes, TsDuplicatePolicy? policy)
{
var args = new List<object> { key, timestamp.Value, value };
args.AddRetentionTime(retentionTime);
Expand Down
5 changes: 3 additions & 2 deletions src/NRedisStack/TimeSeries/TimeSeriesCommands.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public TimeSeriesCommands(IDatabase db) : base(db)
#region Create

/// <inheritdoc/>
public bool Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)
public bool Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel>? labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)
{
return _db.Execute(TimeSeriesCommandsBuilder.Create(key, retentionTime, labels,

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.
uncompressed, chunkSizeBytes,
Expand All @@ -34,7 +34,7 @@ public bool Alter(string key, long? retentionTime = null, long? chunkSizeBytes =

/// <inheritdoc/>
public TimeStamp Add(string key, TimeStamp timestamp, double value, long? retentionTime = null,
IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null,
IReadOnlyCollection<TimeSeriesLabel>? labels = null, bool? uncompressed = null,
long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)
{
return _db.Execute(TimeSeriesCommandsBuilder.Add(key, timestamp, value, retentionTime, labels,

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 40 in src/NRedisStack/TimeSeries/TimeSeriesCommands.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.
Expand Down Expand Up @@ -195,6 +195,7 @@ public IReadOnlyList<TimeSeriesTuple> RevRange(string key,
#region General

/// <inheritdoc/>
[Obsolete]
public TimeSeriesInformation Info(string key, bool debug = false)
{
return _db.Execute(TimeSeriesCommandsBuilder.Info(key, debug)).ToTimeSeriesInfo();
Expand Down
5 changes: 3 additions & 2 deletions src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public TimeSeriesCommandsAsync(IDatabaseAsync db)
#region Create

/// <inheritdoc/>
public async Task<bool> CreateAsync(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)
public async Task<bool> CreateAsync(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel>? labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)
{
return (await _db.ExecuteAsync(TimeSeriesCommandsBuilder.Create(key, retentionTime, labels,

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 19 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Create(string key, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.
uncompressed, chunkSizeBytes,
Expand All @@ -32,7 +32,7 @@ public async Task<bool> AlterAsync(string key, long? retentionTime = null, long?
}

/// <inheritdoc/>
public async Task<TimeStamp> AddAsync(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)
public async Task<TimeStamp> AddAsync(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel>? labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)
{
return (await _db.ExecuteAsync(TimeSeriesCommandsBuilder.Add(key, timestamp, value, retentionTime, labels,

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / doctests

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack edge] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack cluster] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 6 on [redis-stack 7.2.0-RC3] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.

Check warning on line 37 in src/NRedisStack/TimeSeries/TimeSeriesCommandsAsync.cs

View workflow job for this annotation

GitHub Actions / .NET 7 on [redis-stack 6.2.6] / Test

Possible null reference argument for parameter 'labels' in 'SerializedCommand TimeSeriesCommandsBuilder.Add(string key, TimeStamp timestamp, double value, long? retentionTime = null, IReadOnlyCollection<TimeSeriesLabel> labels = null, bool? uncompressed = null, long? chunkSizeBytes = null, TsDuplicatePolicy? duplicatePolicy = null)'.
uncompressed, chunkSizeBytes, duplicatePolicy))).ToTimeStamp();
Expand Down Expand Up @@ -192,6 +192,7 @@ public async Task<IReadOnlyList<TimeSeriesTuple>> RevRangeAsync(string key,
#region General

/// <inheritdoc/>
[Obsolete]
public async Task<TimeSeriesInformation> InfoAsync(string key, bool debug = false)
{
return (await _db.ExecuteAsync(TimeSeriesCommandsBuilder.Info(key, debug))).ToTimeSeriesInfo();
Expand Down

0 comments on commit af1b585

Please sign in to comment.